This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove the tests for rotate and crop from the Android scenario_app.
#51769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Mar 29, 2024
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/51769, due to - The status or check suite Linux linux_android_emulator_skia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
…146007) flutter/engine@32c9dab...4c079a6 2024-03-29 [email protected] Remove the tests for `rotate` and `crop` from the Android `scenario_app`. (flutter/engine#51769) 2024-03-29 [email protected] [Impeller] split out aiks blend tests (flutter/engine#51780) 2024-03-29 [email protected] [macOS] Move to new present callback (flutter/engine#51436) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#145957.
As @jonahwilliams and @johnmccutchan and I discussed (flutter/flutter#144407), the functionality that was being tested was actually Android's ability to rotate and crop
SurfaceTexture-backed textures. This same functionality doesn't even exist in theImageReader-based textures (read: modern Android devices):We might decide to re-add this functionality in the Dart
Texturewidget, but given we'll be migrating our plugins toSurfaceProducer(again, read: usingImageTexturefor most Android phones), it's pointless to test this (and isn't even testing Flutter's code).This reduces our test suite significantly (8 tests down to 2), which should also help with runtime and flakiness.
/cc @zanderso who I'm sure will be stoked.