This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fix plus blend mode in porterduff shader. #51792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
After:
Note: I have no idea why the position changes some times, I think that is just a bug in the widget but 🤷♂️ |
gaaclarke
reviewed
Mar 29, 2024
impeller/entity/entity_unittests.cc
Outdated
| @@ -1446,6 +1446,45 @@ TEST_P(EntityTest, DrawAtlasNoColor) { | |||
| ASSERT_TRUE(OpenPlaygroundHere(std::move(e))); | |||
| } | |||
|
|
|||
| TEST_P(EntityTest, F16WideGamutDrawAtlasPlus) { | |||
There was a problem hiding this comment.
This isn't going to be wide gamut, the name of the test has to end with "WideGamut". Can you add an assert that it is applied like the other ones please.
jonahwilliams
commented
Mar 30, 2024
impeller/entity/entity_unittests.cc
Outdated
| @@ -1446,6 +1446,48 @@ TEST_P(EntityTest, DrawAtlasNoColor) { | |||
| ASSERT_TRUE(OpenPlaygroundHere(std::move(e))); | |||
| } | |||
|
|
|||
| TEST_P(EntityTest, DrawAtlasPlusWideGamut) { | |||
There was a problem hiding this comment.
Did I need to opt this into a golden somewhere?
There was a problem hiding this comment.
Aiks unittests are the only ones that generate goldens.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2024
…146157) flutter/engine@5bf8b94...c60b00a 2024-04-02 [email protected] Allow creating slimpeller engine variants. (flutter/engine#51824) 2024-04-02 [email protected] [Impeller] fix plus blend mode in porterduff shader. (flutter/engine#51792) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DrawAtlas already has the optimization in #51778 and so it is still rendering incorrectly with wide gamut.