Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove log statements that did not help. #51825

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

matanlurey
Copy link
Contributor

Introduced in #51789, but none of the crashes/hangs on CI seem related to these events, so removing.

@matanlurey matanlurey requested a review from jonahwilliams April 1, 2024 20:43
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2024
@auto-submit auto-submit bot merged commit 9cc9cdc into flutter:main Apr 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 2, 2024
…sions) (#146108)

Manual roll requested by [email protected]

Cannot build log URL because revision "9a513de65251" is invalid: Luci builds of "Linux linux_android_emulator_skia_tests" for 9a513de65251f83a43d979bb0b2d4c8ee2f8c417 was FAILURE

2024-04-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818)" (flutter/engine#51835)
2024-04-01 [email protected] Run and record `adb shell screenrecord` during Android scenario app (flutter/engine#51832)
2024-04-01 [email protected] Roll Skia from 0b0ed6ca101b to fe64c32d7f2e (4 revisions) (flutter/engine#51831)
2024-04-01 [email protected] Run the `DrawSolidBlueScreenTest` 5x in a row in bringup builds. (flutter/engine#51829)
2024-04-01 [email protected] Remove tests related to StrictMode that were never running on CI. (flutter/engine#51827)
2024-04-01 [email protected] [Impeller] Ignore warnign about shader stages not consuming outputs. (flutter/engine#51822)
2024-04-01 [email protected] [Skwasm] Forward text height from paragraph height to default text style (flutter/engine#51819)
2024-04-01 [email protected] Remove log statements that did not help. (flutter/engine#51825)
2024-04-01 [email protected] Roll Skia from 40c436a785fa to 0b0ed6ca101b (6 revisions) (flutter/engine#51823)
2024-04-01 [email protected] [Impeller] Add a TextureGLES API for wrapping a framebuffer and use it to implement OpenGL FBO targets in the embedder library (flutter/engine#51269)
2024-04-01 [email protected] Remove `testing/android_background_image` which does not run/exist on CI. (flutter/engine#51815)
2024-04-01 [email protected] [Impeller] Avoid loading redundant Vulkan extensions. (flutter/engine#51818)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants