This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Be slightly more lenient about the assertion, as it differs on different backends. #51877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Apr 3, 2024
yjbanov
approved these changes
Apr 3, 2024
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2024
… on different backends. (flutter/engine#51877)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2024
… on different backends. (flutter/engine#51877)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2024
…146240) flutter/engine@349608d...18fdcad 2024-04-03 [email protected] Roll Skia from 8d7482b998d0 to 7d6dce620e46 (1 revision) (flutter/engine#51878) 2024-04-03 [email protected] Be slightly more lenient about the assertion, as it differs on different backends. (flutter/engine#51877) 2024-04-03 [email protected] Roll Skia from afa233bb1979 to 8d7482b998d0 (2 revisions) (flutter/engine#51876) 2024-04-03 [email protected] [Impeller] Enable logging a warning when the user opts out of using Impeller. (flutter/engine#51849) 2024-04-03 [email protected] [Impeller] delete unused code. (flutter/engine#51871) 2024-04-03 [email protected] [Impeller] eliminate sub-render pass for blended color + texture vertices. (flutter/engine#51778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't assume the exact format of the assertion string here, as the exact output is slightly different on dart2js vs ddc vs dart2wasm. They should all contain the message text, however.