Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Move EGL surface creation #51920

Merged

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Apr 4, 2024

This is a refactoring with no semantic changes.

The engine can start rendering into a view once it's received the view's initial window metrics. In a multi-view world, the initial window metrics will be sent by FlutterEngineAddView, which will be called by FlutterWindowsEngine::CreateView.

This change creates the view's EGL surface earlier, in FlutterWindowsEngine::CreateView, to prepare for multi-view rendering.

Prepares for flutter/flutter#144810
Part of flutter/flutter#142845

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title [Windows] Prepare to add/remove views [Windows] Move EGL surface creation Apr 4, 2024
@loic-sharma loic-sharma force-pushed the windows_create_render_surface branch from 1c8f022 to 8c93994 Compare April 4, 2024 21:49
@loic-sharma loic-sharma marked this pull request as ready for review April 4, 2024 21:50
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2024
@auto-submit auto-submit bot merged commit e57eb35 into flutter:main Apr 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 5, 2024
…146370)

flutter/engine@48604df...b503915

2024-04-05 [email protected] Roll Skia from d596d9e4cb4f to d0f229153ae7 (2 revisions) (flutter/engine#51946)
2024-04-05 [email protected] [Impeller] handle fill polylines with zero area. (flutter/engine#51945)
2024-04-05 [email protected] [Windows] Move EGL surface creation (flutter/engine#51920)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146370)

flutter/engine@48604df...b503915

2024-04-05 [email protected] Roll Skia from d596d9e4cb4f to d0f229153ae7 (2 revisions) (flutter/engine#51946)
2024-04-05 [email protected] [Impeller] handle fill polylines with zero area. (flutter/engine#51945)
2024-04-05 [email protected] [Windows] Move EGL surface creation (flutter/engine#51920)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants