Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Remove StC flag. #51992

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

bdero
Copy link
Member

@bdero bdero commented Apr 9, 2024

It is time.

@bdero bdero self-assigned this Apr 9, 2024
@bdero
Copy link
Member Author

bdero commented Apr 9, 2024

I will follow-up with other cleanups to remove the old depth tracking and libtess.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We do still have some code that is using libtess, so while we remove our usage of in the tessellator, there is a C folder that we should keep. vector_graphics is using that binary to do offline tessellation.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Adding visibility = [ ":*" ] to the tessellator component should help you shake out the uses of the tessellator and libtess.

@bdero bdero merged commit 67c01d5 into flutter:main Apr 9, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2024
bdero added a commit that referenced this pull request Apr 9, 2024
Follow-up for #51992.

This is now dead code.
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 9, 2024
…146527)

flutter/engine@5dca50d...e4e2748

2024-04-09 [email protected] Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998)
2024-04-09 [email protected] [Impeller] Remove StC flag. (flutter/engine#51992)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero added a commit that referenced this pull request Apr 11, 2024
Another clean-up patch following
#51992.

Also, don't rely on Entity tracked stencil height for clip coverage
tracking.
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146527)

flutter/engine@5dca50d...e4e2748

2024-04-09 [email protected] Roll Skia from 4281f51749b2 to a86861d21ae1 (23 revisions) (flutter/engine#51998)
2024-04-09 [email protected] [Impeller] Remove StC flag. (flutter/engine#51992)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants