This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix the Dart language version for Fuchsia's build of the args package #52083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for the next Dart roll (see flutter#52077)
chinmaygarde
approved these changes
Apr 12, 2024
devoncarew
reviewed
Apr 12, 2024
| @@ -124,7 +124,7 @@ dart_library("args") { | |||
| package_root = "$dart_src/third_party/pkg/args" | |||
| package_name = "args" | |||
|
|
|||
| pubspec = "$package_root/pubspec.yaml" | |||
| language_version = "2.17" | |||
There was a problem hiding this comment.
I'm curious about this change. The upstream dart sdk CL brought in a version of package:args that now has an sdk requirement of ^3.0.0. Previously it had been '>=2.19.0 <4.0.0'.
Is this file generally auto-maintained / generated as package metadata changes? Manually maintained w/ duplicate info? Should it be parsing the required sdk version out of the pubspec?
There was a problem hiding this comment.
This is a Fuchsia-specific build script for package:args.
I don't know its history, but AFAIK it's manually maintained.
There was a problem hiding this comment.
Gotcha; thanks for the fix!
It looks like the parser does not handle the caret syntax for sdk constraints (^3.0.0):https://github.com/flutter/engine/blob/main/tools/fuchsia/dart/gen_dart_package_config.py#L55
And, the script defaults to Dart 2.8, which is super old. 3.0 might be a better default? Or 2.12? Or no default at all, and just failing, which may be more predictable.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2024
…146698) flutter/engine@6b37b17...0e56e3d 2024-04-12 [email protected] Fix the Dart language version for Fuchsia's build of the args package (flutter/engine#52083) 2024-04-11 [email protected] Update iOS KeyCodeMap dictionary literal and migrate to ARC (flutter/engine#51981) 2024-04-11 [email protected] [Impeller] Only set the stencil ref for StC draws. (flutter/engine#52006) 2024-04-11 [email protected] Remove intermediate APKs during build process. (flutter/engine#52071) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146698) flutter/engine@6b37b17...0e56e3d 2024-04-12 [email protected] Fix the Dart language version for Fuchsia's build of the args package (flutter/engine#52083) 2024-04-11 [email protected] Update iOS KeyCodeMap dictionary literal and migrate to ARC (flutter/engine#51981) 2024-04-11 [email protected] [Impeller] Only set the stencil ref for StC draws. (flutter/engine#52006) 2024-04-11 [email protected] Remove intermediate APKs during build process. (flutter/engine#52071) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for the next Dart roll (see #52077)