Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] move AccessibilityAnnouncements into SemanticsOwner #52138

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 15, 2024

Move AccessibilityAnnouncements into SemanticsOwner, effectively making it a singleton (because SemanticsOwner is).

Fixes flutter/flutter#139272

@yjbanov yjbanov requested review from ditman and mdebbar April 15, 2024 22:10
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Apr 15, 2024
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning this up!

@ditman
Copy link
Member

ditman commented Apr 15, 2024

The DOM manager seems to be complaining (maybe others):

00:23 +654 ~26 -1: view_embedder/dom_manager_test.dart: DomManager DOM tree looks right [E]                                                                                                            
  Expected: <3>
    Actual: <2>
  
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1190:19                           Object.wrapException
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1231:28                           Object.throwExpression
  ..\home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 149:31    Object.fail
  ..\home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 144:3     Object._expect
  ..\home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 56:3      Object.expect
  view_embedder\dom_manager_test.dart 41:7                                                          doTests.<fn>.<fn>
  ..\home\chrome-bot\.pub-cache\hosted\pub.dev\test_api-0.6.1\lib\src\backend\declarer.dart 215:15  <fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 303:19                          _wrapJsFunctionForAsync.closure.$protected
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 328:23                          _wrapJsFunctionForAsync.<fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 279:19                          _awaitOnObject.<fn>
  

To run this test again: C:\b\s\w\ir\cache\builder\src\flutter\prebuilts\windows-x64\dart-sdk\bin\dart test view_embedder/dom_manager_test.dart -p chrome --plain-name "DomManager DOM tree looks right"

@yjbanov
Copy link
Contributor Author

yjbanov commented Apr 17, 2024

Fixed.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024
@auto-submit auto-submit bot merged commit bc6382e into flutter:main Apr 17, 2024
29 checks passed
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 17, 2024
…146930)

flutter/engine@818191d...bc6382e

2024-04-17 [email protected] [web] move AccessibilityAnnouncements into SemanticsOwner (flutter/engine#52138)
2024-04-17 [email protected] [Windows] Add/remove view failures should not hang (flutter/engine#52164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146930)

flutter/engine@818191d...bc6382e

2024-04-17 [email protected] [web] move AccessibilityAnnouncements into SemanticsOwner (flutter/engine#52138)
2024-04-17 [email protected] [Windows] Add/remove view failures should not hang (flutter/engine#52164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web:multi-view] AccessibilityAnnouncements should be a singleton
2 participants