This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[skwasm] Change default FilterQuality to None for image shaders.
#52468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 1, 2024
…147649) flutter/engine@0ce6771...0014e03 2024-05-01 [email protected] Fix et run (flutter/engine#52477) 2024-05-01 [email protected] Roll Skia from 5f4ebd628994 to bfbd738fb97b (2 revisions) (flutter/engine#52479) 2024-05-01 [email protected] Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1... (flutter/engine#52480) 2024-05-01 [email protected] Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (flutter/engine#52478) 2024-05-01 [email protected] Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (flutter/engine#52476) 2024-05-01 [email protected] [Impeller] Document the EGL toolkit. (flutter/engine#52469) 2024-05-01 [email protected] [skwasm] Change default `FilterQuality` to `None` for image shaders. (flutter/engine#52468) 2024-05-01 [email protected] Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (flutter/engine#52475) 2024-04-30 [email protected] Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (flutter/engine#52471) 2024-04-30 [email protected] Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (flutter/engine#52466) 2024-04-30 [email protected] Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (flutter/engine#52465) 2024-04-30 [email protected] Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (flutter/engine#52464) 2024-04-30 [email protected] Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (flutter/engine#52460) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HP2saK9sVOtK to PIHl-e41i3mz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the behavior in line with the CanvasKit renderer, which also uses
Nonefor the default image shader quality.I added a few unit tests to cover different filter qualities. It turns out, there is a skia issue that manifests both in CanvasKit and Skwasm when a lazy image is rendered with medium quality. See https://g-issues.skia.org/issues/338095525