Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

When et is not attached to a terminal, still split lines for status updates. #52681

Merged
merged 3 commits into from
May 9, 2024
Merged

When et is not attached to a terminal, still split lines for status updates. #52681

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ced03d7
Better support for et when not isTty
matanlurey May 8, 2024
ded46e3
++
matanlurey May 9, 2024
11328ea
++
matanlurey May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/engine_tool/lib/src/logger.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ class Logger {
/// and emits a carriage return.
void clearLine() {
if (!io.stdout.hasTerminal || _test) {
// Just write a newline if we're not in a terminal.
_ioSinkWrite(io.stdout, '\n');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc comment for the behavior change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

return;
}
_status?.pause();
Expand Down