Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Followup feedback on "Baby's First Triangle". #52718

Merged
merged 1 commit into from
May 11, 2024

Conversation

chinmaygarde
Copy link
Member

Addresses comments made after #52703 landed.

@@ -162,7 +162,7 @@ And in the body, set the color of the fragment to the this input.
frag_color = v_color;
```

Notice we didn't do anything to perform the color mixing. That's because the rasterizer interpolates the values between stages. Since the varies depending on the pixel, we call these "varyings" and use the `v_` prefix for such variables.
We didn't do anything to perform the color mixing. That's because the rasterizer interpolates the values between stages. Since the varies depending on the pixel, we call these "varyings" and use the `v_` prefix for such variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial nit, feel free to ignore

Maybe "We didn't do anything to perform the color mixing because the rasterizer interpolates..."?

Whichever, either's fine.

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 11, 2024
@auto-submit auto-submit bot merged commit da601e5 into flutter:main May 11, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 11, 2024
…148163)

flutter/engine@fad88cb...558a81d

2024-05-11 [email protected] Roll Dart SDK from de30a5dbf169 to cbfaae24852c (2 revisions) (flutter/engine#52730)
2024-05-11 [email protected] [Impeller] Followup feedback on "Baby's First Triangle". (flutter/engine#52718)
2024-05-11 [email protected] Roll Dart SDK from 13fc7db956c7 to de30a5dbf169 (1 revision) (flutter/engine#52728)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde deleted the followup_baby branch May 13, 2024 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants