Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Reland "Fix focus management for text fields (#51009)" #53537

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[web] Reland "Fix focus management for text fields (#51009)" #53537

merged 2 commits into from
Jun 24, 2024

Conversation

ditman
Copy link
Member

@ditman ditman commented Jun 24, 2024 •
edited
Loading

Relands: Fix focus management for text fields (#51009) by:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested review from mdebbar and tugorez June 24, 2024 19:23
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Jun 24, 2024
@ditman ditman mentioned this pull request Jun 24, 2024
Merged
8 tasks
mdebbar
mdebbar approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tugorez
tugorez approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@tugorez tugorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2024
@auto-submit auto-submit bot merged commit 63c2403 into flutter:main Jun 24, 2024
29 checks passed
@ditman
Copy link
Member Author

ditman commented Jun 24, 2024

Let's hope this sticks, we'll most likely need a g3fix for the ViewFocusBinding flag.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
c2be14b 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
556bdf4 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
49d5bdd 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
609ce26 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
5a1f130 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
8a20c84 
…#51009)" (flutter/engine#53537)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
63c240384 [web] Reland "Fix focus management for text fields (flutter…
ed3c87b 
…#51009)" (flutter/engine#53537)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 25, 2024
@engine-flutter-autoroll
Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (#…
c9f72d5 
…150762)

flutter/engine@be7db94...afa7ce1

2024-06-25 [email protected] Roll Dart SDK from bb18127b2a8e to b5fc85cfcf1b (1 revision) (flutter/engine#53552)
2024-06-25 [email protected] Roll Skia from 5feca3095719 to 335200e57c26 (1 revision) (flutter/engine#53549)
2024-06-25 [email protected] Roll Dart SDK from c187d4b3ec88 to bb18127b2a8e (1 revision) (flutter/engine#53547)
2024-06-25 [email protected] Roll Fuchsia Linux SDK from _6HNhJ6G59VMceKoN... to WUN7NQK04NjF9fRmf... (flutter/engine#53545)
2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Re-re-land "Upgrade all[most] androidx dependencies to latest" (#53532)" (flutter/engine#53546)
2024-06-25 [email protected] Bump impeller-cmake-example (flutter/engine#53538)
2024-06-24 [email protected] Roll Skia from e20c8b0bac0c to 5feca3095719 (1 revision) (flutter/engine#53544)
2024-06-24 [email protected] [web] Reland "Fix focus management for text fields (#51009)" (flutter/engine#53537)
2024-06-24 [email protected] Roll Dart SDK from 5df89347bddf to c187d4b3ec88 (1 revision) (flutter/engine#53542)
2024-06-24 [email protected] [macOS] Generate universal gen_snapshots (flutter/engine#53524)
2024-06-24 [email protected] Re-re-land "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53532)
2024-06-24 [email protected] Roll Skia from 1948fd53e280 to e20c8b0bac0c (1 revision) (flutter/engine#53540)
2024-06-24 [email protected] Roll Skia from 0fa58b6ddba0 to 1948fd53e280 (2 revisions) (flutter/engine#53536)
2024-06-24 [email protected] Roll Skia from ea84df425483 to 0fa58b6ddba0 (3 revisions) (flutter/engine#53535)
2024-06-24 [email protected] [Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow (flutter/engine#53466)
2024-06-24 [email protected] [fuchsia] Update Fuchsia API level to 19 (flutter/engine#53494)
2024-06-24 [email protected] Roll Dart SDK from 95470b2cac1f to 5df89347bddf (1 revision) (flutter/engine#53534)
2024-06-24 [email protected] Roll Skia from f6b4344d73cc to ea84df425483 (1 revision) (flutter/engine#53531)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from _6HNhJ6G59VM to WUN7NQK04NjF

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Satsrag Satsrag mentioned this pull request Jan 18, 2025
Closed
@elitree elitree mentioned this pull request Mar 19, 2025
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdebbar mdebbar mdebbar approved these changes

@tugorez tugorez tugorez approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @mdebbar @tugorez