This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML (#45166)" #53725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jul 4, 2024
auto-submit
bot
deleted the
revert_c90aa9a512c8b4d2f33ca3a981ed3acc4ebc6c5d
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2024
…er on Flutter web HTML (flutter#45166)" (flutter/engine#53725)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 4, 2024
…151299) flutter/engine@8e2d05f...2b6bb51 2024-07-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML (#45166)" (flutter/engine#53725) 2024-07-04 [email protected] [Impeller] mark the end of a frame boundary for system compositor interop. (flutter/engine#53722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TahaTesser
pushed a commit
to TahaTesser/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151299) flutter/engine@8e2d05f...2b6bb51 2024-07-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter#45166)" (flutter/engine#53725) 2024-07-04 [email protected] [Impeller] mark the end of a frame boundary for system compositor interop. (flutter/engine#53722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151299) flutter/engine@8e2d05f...2b6bb51 2024-07-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter#45166)" (flutter/engine#53725) 2024-07-04 [email protected] [Impeller] mark the end of a frame boundary for system compositor interop. (flutter/engine#53722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #45166
Initiated by: jiahaog
Reason for reverting: #45166 (comment)
Original PR Author: Kingtous
Reviewed By: {yjbanov, harryterkelsen}
This change reverts the following previous change:
Hi from Dora team, which powers web developers to build their 3d websites in just a few seconds.
This PR fixes: flutter/flutter#133443, related: flutter/flutter#58546
The original codes attempts to cache the css string but it causes bugs when encountering nested the same mask filter blur. We should also set
filterproperties when currentFilter == incoming mask filter using the cached css string, not just ignore it.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.