This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] adds test for catching shimmer in gaussian blur #54116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
gaaclarke
added a commit
that referenced
this pull request
Jul 26, 2024
…ls. (#53760)" (#54148) This is reverted since it introduces shimmering when the downsample scalar goes to 1/16th. It was reverted instead of fixed to allow the test that should have blocked this to land in the meantime. reverts #53760 fixed and relanded in #54149 Part of a series of gaussian blur changes: 1) #54148 1) #54116 1) #54150 1) #54149 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2024
…152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…he downsample padding (#54150) This removes jitter in the gaussian blur. Previous version of the shimmer test show this drops the average RMSE 30%. testing: - positive change shown in average RMSE in ShimmerTest - existing golden tests Part of a series of gaussian blur changes: 1) #54148 1) #54116 1) #54150 1) #54149 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…ls. (#54149) relands #53760 reverted in #54148 The fix for this was found with the help of Jonah. Part of a series of gaussian blur changes: 1) #54148 1) #54116 1) #54150 1) #54149 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (flutter#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152414) flutter/engine@e28f875...0c5504e 2024-07-26 [email protected] [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 2024-07-26 [email protected] Revert "[Impeller] Use downsample shader for blur instead of mip levels. (flutter#53760)" (flutter/engine#54148) 2024-07-26 [email protected] Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 2024-07-26 [email protected] Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 2024-07-26 [email protected] Pub workspace-ify most of `testing/` and parts of `tools/` (flutter/engine#54124) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#152195
Part of a series of gaussian blur changes:
Note: this test won't pass until #54148 lands.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.