Reland: Partial repaint platform views #54231

knopp · 2024-07-30T21:19:21Z

Relands #54219 reverted in #54230.

The tracked area of PlatformViewLayer now covers entire frame ensuring full repaint when platform view is removed.
Added FullRepaintAfterRemovingLayer test.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jonahwilliams

LGTM

…153035) flutter/engine@5a0fd5f...69c29fb 2024-08-07 [email protected] Reland: Partial repaint platform views (flutter/engine#54231) 2024-08-07 [email protected] Roll Skia from 5267a5a1e26a to 0c6dd1e6ff8e (1 revision) (flutter/engine#54392) 2024-08-07 [email protected] Roll Skia from a0e775f706cd to 5267a5a1e26a (1 revision) (flutter/engine#54389) 2024-08-07 [email protected] Roll Skia from 968a00456bc5 to a0e775f706cd (3 revisions) (flutter/engine#54386) 2024-08-07 [email protected] Roll buildroot to 6ef931b950d5b9477dba0e278b7006ae327e12f7 (flutter/engine#54384) 2024-08-07 [email protected] Roll Fuchsia Test Scripts from oOZyP3ets0uHdEqWW... to 3FWYCLt6cV86gWU8E... (flutter/engine#54382) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#153035) flutter/engine@5a0fd5f...69c29fb 2024-08-07 [email protected] Reland: Partial repaint platform views (flutter/engine#54231) 2024-08-07 [email protected] Roll Skia from 5267a5a1e26a to 0c6dd1e6ff8e (1 revision) (flutter/engine#54392) 2024-08-07 [email protected] Roll Skia from a0e775f706cd to 5267a5a1e26a (1 revision) (flutter/engine#54389) 2024-08-07 [email protected] Roll Skia from 968a00456bc5 to a0e775f706cd (3 revisions) (flutter/engine#54386) 2024-08-07 [email protected] Roll buildroot to 6ef931b950d5b9477dba0e278b7006ae327e12f7 (flutter/engine#54384) 2024-08-07 [email protected] Roll Fuchsia Test Scripts from oOZyP3ets0uHdEqWW... to 3FWYCLt6cV86gWU8E... (flutter/engine#54382) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

zanderso · 2024-08-13T14:29:16Z

Reason for revert: Suspected cause of flutter/flutter#153335

auto-submit · 2024-08-13T14:29:58Z

Time to revert pull request flutter/engine/54231 has elapsed.
You need to open the revert manually and process as a regular pull request.

This reverts commit 69c29fb.

Reverts #54231 Speculatively reverting for flutter/flutter#153335

…lutter#153035) flutter/engine@5a0fd5f...69c29fb 2024-08-07 [email protected] Reland: Partial repaint platform views (flutter/engine#54231) 2024-08-07 [email protected] Roll Skia from 5267a5a1e26a to 0c6dd1e6ff8e (1 revision) (flutter/engine#54392) 2024-08-07 [email protected] Roll Skia from a0e775f706cd to 5267a5a1e26a (1 revision) (flutter/engine#54389) 2024-08-07 [email protected] Roll Skia from 968a00456bc5 to a0e775f706cd (3 revisions) (flutter/engine#54386) 2024-08-07 [email protected] Roll buildroot to 6ef931b950d5b9477dba0e278b7006ae327e12f7 (flutter/engine#54384) 2024-08-07 [email protected] Roll Fuchsia Test Scripts from oOZyP3ets0uHdEqWW... to 3FWYCLt6cV86gWU8E... (flutter/engine#54382) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flar · 2024-08-27T09:41:10Z

This PR also caused some performance regressions in some benchmarks. For instance:
https://flutter-flutter-perf.skia.org/e/?begin=1722245801&end=1724724632&keys=X83b311abfba6278795b9fa6fefd147de&requestType=0&selected=commit%3D42140%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253D90th_percentile_frame_rasterizer_time_millis%252Ctest%253Dpost_backdrop_filter_perf_ios__timeline_summary%252C&xbaroffset=42140

knopp · 2024-08-27T16:36:18Z

I think the regressions were caused by the revert? #54537. This can be relanded again without changes now that #54540 is merged. I'll make a PR.

flar · 2024-08-27T18:14:53Z

I think the regressions were caused by the revert? #54537. This can be relanded again without changes now that #54540 is merged. I'll make a PR.

Oh, right. I triaged so many benchmark changes last night that I got that backwards.

…lutter#153035) flutter/engine@5a0fd5f...69c29fb 2024-08-07 [email protected] Reland: Partial repaint platform views (flutter/engine#54231) 2024-08-07 [email protected] Roll Skia from 5267a5a1e26a to 0c6dd1e6ff8e (1 revision) (flutter/engine#54392) 2024-08-07 [email protected] Roll Skia from a0e775f706cd to 5267a5a1e26a (1 revision) (flutter/engine#54389) 2024-08-07 [email protected] Roll Skia from 968a00456bc5 to a0e775f706cd (3 revisions) (flutter/engine#54386) 2024-08-07 [email protected] Roll buildroot to 6ef931b950d5b9477dba0e278b7006ae327e12f7 (flutter/engine#54384) 2024-08-07 [email protected] Roll Fuchsia Test Scripts from oOZyP3ets0uHdEqWW... to 3FWYCLt6cV86gWU8E... (flutter/engine#54382) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

knopp force-pushed the partial_repaint_platform_views branch from 38f3e4b to d7bb98e Compare July 30, 2024 21:21

knopp requested a review from jonahwilliams July 30, 2024 21:21

jonahwilliams approved these changes Jul 31, 2024

View reviewed changes

knopp added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 31, 2024

knopp added 3 commits August 7, 2024 07:50

Do not disable partial repaint based on thread merging state

b287247

Do full repaint after removing platform view

950e487

Add test

121941f

knopp force-pushed the partial_repaint_platform_views branch from d7bb98e to 121941f Compare August 7, 2024 05:50

knopp merged commit 69c29fb into flutter:main Aug 7, 2024
26 checks passed

knopp deleted the partial_repaint_platform_views branch August 7, 2024 16:14

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Flutter Engine from 5a0fd5fbecc6 to 69c29fb309bb (6 revisions) flutter/flutter#153035

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

69c29fb30 Reland: Partial repaint platform views (flutter/engine#54231)

6eef2a9

jacobsimionato mentioned this pull request Aug 13, 2024

Google Maps rendering glitches caused by Engine change flutter/flutter#153335

Closed

zanderso added the revert Label used to revert changes in a closed and merged pull request. label Aug 13, 2024

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Aug 13, 2024

zanderso added a commit that referenced this pull request Aug 13, 2024

Revert "Reland: Partial repaint platform views (#54231)"

af400d7

This reverts commit 69c29fb.

zanderso mentioned this pull request Aug 13, 2024

Revert "Reland: Partial repaint platform views" #54537

Merged

zanderso added a commit that referenced this pull request Aug 13, 2024

Revert "Reland: Partial repaint platform views" (#54537)

4246f15

Reverts #54231 Speculatively reverting for flutter/flutter#153335

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland: Partial repaint platform views #54231

Reland: Partial repaint platform views #54231

Uh oh!

knopp commented Jul 30, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

Uh oh!

zanderso commented Aug 13, 2024

Uh oh!

auto-submit bot commented Aug 13, 2024

Uh oh!

flar commented Aug 27, 2024

Uh oh!

knopp commented Aug 27, 2024

Uh oh!

flar commented Aug 27, 2024

Uh oh!

Uh oh!

Reland: Partial repaint platform views #54231

Reland: Partial repaint platform views #54231

Uh oh!

Conversation

knopp commented Jul 30, 2024

Pre-launch Checklist

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zanderso commented Aug 13, 2024

Uh oh!

auto-submit bot commented Aug 13, 2024

Uh oh!

flar commented Aug 27, 2024

Uh oh!

knopp commented Aug 27, 2024

Uh oh!

flar commented Aug 27, 2024

Uh oh!

Uh oh!