Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "FlutterFragment predictive back" #54256

Closed
wants to merge 1 commit into from

Conversation

justinmc
Copy link
Contributor

Reverts #52302, which seems to have broken back gestures for certain Google customers.

At least 2 Google-specific bugs caused by this:
b/354579427
b/355556397

@justinmc justinmc requested a review from jiahaog July 31, 2024 17:43
@justinmc justinmc self-assigned this Jul 31, 2024
Copy link
Member

@jiahaog jiahaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbaker
Copy link
Contributor

Are you sure this is the right call? The Original PR handled that predictive back was not working in flutter fragments. It seems to me that this semi broken state is potentially worse than the regressions.

@reidbaker reidbaker self-requested a review August 1, 2024 18:24
@justinmc
Copy link
Contributor Author

justinmc commented Aug 2, 2024

Predictive back is non-critical feature that is still unreleased on native Android, though, so removing support for it is probably not a big deal. Meanwhile some of those bugs had problems with navigation in general.

I'll keep this open and come back to this next week, but if anyone needs an immediate fix for this, I think it's ok to merge.

@jiahaog
Copy link
Member

jiahaog commented Aug 3, 2024

The internal team needs this to unblock their release with some urgency, so it'll be good to land this / some other fix soon 🙂

@reidbaker
Copy link
Contributor

The internal team needs this to unblock their release with some urgency, so it'll be good to land this / some other fix soon 🙂

OK, I trust yall to make the right decisions here.

@yaakovschectman
Copy link
Contributor

From triage: What is stopping this revert from landing?

@chinmaygarde
Copy link
Member

Triage: Justin says we should wait on landing this. But he will be ready to pull the trigger soonish.

@chinmaygarde
Copy link
Member

There seems to be some ongoing conversation in the internal threads. Assuming this is still WIP.

@gmackall
Copy link
Member

From android triage: Looks like there is still discussion on internal threads, still assuming this is WIP

@justinmc
Copy link
Contributor Author

Actually I'll go ahead and close this to get it off of triage lists unless something urgent comes up and it's needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants