-
Notifications
You must be signed in to change notification settings - Fork 6k
Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" #54552
Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" #54552
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
…sions) (#153413) Manual roll requested by [email protected] flutter/engine@019f9e3...5909666 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549) 2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546) 2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484) 2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529) 2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543) 2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541) 2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542) 2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483) 2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540) 2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…sions) (flutter#153413) Manual roll requested by [email protected] flutter/engine@019f9e3...5909666 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter#54541)" (flutter/engine#54552) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (flutter#54543)" (flutter/engine#54550) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (flutter#54546)" (flutter/engine#54549) 2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546) 2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484) 2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529) 2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543) 2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541) 2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542) 2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483) 2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540) 2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…sions) (flutter#153413) Manual roll requested by [email protected] flutter/engine@019f9e3...5909666 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter#54541)" (flutter/engine#54552) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (flutter#54543)" (flutter/engine#54550) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (flutter#54546)" (flutter/engine#54549) 2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546) 2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484) 2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529) 2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543) 2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541) 2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542) 2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483) 2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540) 2024-08-13 6844906[email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Reverts: #54541
Initiated by: zanderso
Reason for reverting: Analyzer change incorrectly flags unused final field as uninitialized? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8739656817167901393/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/44635f897535..733062367c2e
2024-08-13 [email protected] Version 3.6.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md