Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Unskip Impeller iOS scenario tests #55012

Merged
merged 13 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 5 additions & 62 deletions testing/scenario_app/bin/run_ios_tests.dart
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ Future<void> _run(
osVersion: osVersion,
deviceName: deviceName,
iosEngineVariant: iosEngineVariant,
xcodeBuildExtraArgs: [
// Plist with `FTEEnableImpeller=NO`; all projects in the workspace require this file.
// For example, `FlutterAppExtensionTestHost` has a dummy file under the below directory.
r'INFOPLIST_FILE="$(TARGET_NAME)/Info_Skia.plist"',
],
);
cleanup.add(process.kill);

Expand All @@ -161,10 +166,6 @@ Future<void> _run(
osVersion: osVersion,
deviceName: deviceName,
iosEngineVariant: iosEngineVariant,
xcodeBuildExtraArgs: [
..._skipTestsForImpeller,
_infoPlistFPathForImpeller(engine),
],
);
cleanup.add(process.kill);

Expand Down Expand Up @@ -349,64 +350,6 @@ Future<io.Process> _runTests({
);
}

/// -skip-testing {$name} args required to pass the Impeller tests.
///
/// - Skip testFontRenderingWhenSuppliedWithBogusFont: https://github.com/flutter/flutter/issues/113250
/// - Skip golden tests that use software rendering: https://github.com/flutter/flutter/issues/131888
final _skipTestsForImpeller = [
'ScenariosUITests/MultiplePlatformViewsBackgroundForegroundTest/testPlatformView',
'ScenariosUITests/MultiplePlatformViewsTest/testPlatformView',
'ScenariosUITests/NonFullScreenFlutterViewPlatformViewUITests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipPathTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipPathMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipPathWithTransformTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipPathWithTransformMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectAfterMovedTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectAfterMovedMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectWithTransformTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRectWithTransformMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRRectTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRRectMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRRectWithTransformTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationClipRRectWithTransformMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationLargeClipRRectTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationLargeClipRRectMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationLargeClipRRectWithTransformTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationLargeClipRRectWithTransformMultipleClipsTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationOpacityTests/testPlatformView',
'ScenariosUITests/PlatformViewMutationTransformTests/testPlatformView',
'ScenariosUITests/PlatformViewRotation/testPlatformView',
'ScenariosUITests/PlatformViewUITests/testPlatformView',
'ScenariosUITests/PlatformViewWithNegativeOtherBackDropFilterTests/testPlatformView',
'ScenariosUITests/PlatformViewWithOtherBackdropFilterTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipPathTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipPathMultipleClipsTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipRectTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipRectMultipleClipsTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipRRectTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewClipRRectMultipleClipsTests/testPlatformView',
'ScenariosUITests/TwoPlatformViewsWithOtherBackDropFilterTests/testPlatformView',
'ScenariosUITests/UnobstructedPlatformViewTests/testMultiplePlatformViewsWithOverlays',
].map((name) => '-skip-testing:$name').toList();

/// Plist with `FTEEnableImpeller=YES`; all projects in the workspace require this file.
///
/// For example, `FlutterAppExtensionTestHost` has a dummy file under the below directory.
String _infoPlistFPathForImpeller(Engine engine) {
final infoPath = path.join(
engine.flutterDir.path,
'testing',
'scenario_app',
'ios',
'Scenarios',
'Scenarios',
'Info_Impeller.plist',
);
return 'INFOPLIST_FILE=$infoPath';
}

@useResult
String _zipAndStoreFailedTestResults({
required String iosEngineVariant,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<!--Dummy plist file to make the impeller version of scenario test happy-->
<!--Dummy plist file to make the Skia version of scenario test happy-->
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<!--This flag does not do anything, it only makes the xcodebuild command happy-->
<key>FLTEnableImpeller</key>
<true/>
<false/>
<key>UIApplicationSceneManifest</key>
<dict>
<key>UIApplicationSupportsMultipleScenes</key>
Expand Down
Loading