This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue #55944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore images are pending in the queue ImageReaderSurfaceProducer will request a frame when an image is enqueued. But there is no guarantee that each request will produce an additional frame. Multiple requests happening within one vsync interval could be merged into one frame. If no other frame is scheduled, then some images will remain in the queue and the image shown on screen will not be the latest image. With this change, ImageReaderSurfaceProducer will continue requesting frames after consuming an image if the queue is not empty. Fixes flutter/flutter#156903 Fixes flutter/flutter#155787
jonahwilliams
approved these changes
Oct 18, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2024
…Image if more images are pending in the queue (flutter/engine#55944)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2024
…157277) flutter/engine@68f9225...1a8ef6e 2024-10-21 [email protected] Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue (flutter/engine#55944) 2024-10-21 [email protected] Roll Dart SDK from c8659684d34d to 10387c3fc6d4 (1 revision) (flutter/engine#55987) 2024-10-21 [email protected] [web] Support woff2 fonts (flutter/engine#55908) 2024-10-21 [email protected] Roll Fuchsia Linux SDK from PWz1ufnYNOGpgw-qg... to avSAUwQTf5xVGuZQU... (flutter/engine#55985) 2024-10-21 [email protected] Manual roll Dart SDK from a51df90298ca to c8659684d34d (4 revisions) (flutter/engine#55984) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from PWz1ufnYNOGp to avSAUwQTf5xV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2024
…#157300) flutter/engine#55944 should have fixed all flakes and rolled into framework.
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ore images are pending in the queue (flutter/engine#55944) ImageReaderSurfaceProducer will request a frame when an image is enqueued. But there is no guarantee that each request will produce an additional frame. Multiple requests happening within one vsync interval could be merged into one frame. If no other frame is scheduled, then some images will remain in the queue and the image shown on screen will not be the latest image. With this change, ImageReaderSurfaceProducer will continue requesting frames after consuming an image if the queue is not empty. Fixes flutter#156903 Fixes flutter#155787
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageReaderSurfaceProducer will request a frame when an image is enqueued. But there is no guarantee that each request will produce an additional frame.
Multiple requests happening within one vsync interval could be merged into one frame. If no other frame is scheduled, then some images will remain in the queue and the image shown on screen will not be the latest image.
With this change, ImageReaderSurfaceProducer will continue requesting frames after consuming an image if the queue is not empty.
Fixes flutter/flutter#156903
Fixes flutter/flutter#155787