This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Increase timeout for Linux mac_clangd #55988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timing out on the release branch.
zanderso
added
the
autosubmit
reidbaker
approved these changes
Oct 21, 2024
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/55988, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2024
…157284) flutter/engine@1a8ef6e...315540e 2024-10-21 [email protected] Increase timeout for Linux mac_clangd (flutter/engine#55988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
…hestrator (#56014) "Orchestrator" builders are top-level builds that can perform some caching, kick off "drone" sub-builds, and then do things with those build artifacts like run tests, or "generators" that do work on those artifacts. See more details in https://flutter.dev/go/engine-build-definition-language. `Linux mac_clangd` is currently set up as an orchestrator builder, but it only kicks off one gn and one test that can be converted to a standalone build. `Linux mac_clangd` is confusingly named because the orchestrator is a Linux machine, but the drone is a Mac. Copy `Linux mac_clangd` into [`ci/builders/standalone`](https://github.com/flutter/engine/tree/30bd6c9e861686581b6f0bca6834413559f6e0ef/ci/builders/standalone) and reference it in a new `Mac clangd` build in `bringup`. Note since we want to rename the builder it can't replace `Linux mac_clangd` in the same commit. I will follow up and remove `Linux mac_clangd` once `Mac clangd` `bringup` is removed. Unfortunately that means we lose commit history. Differences from [ci/builders/mac_unopt_debug_no_rbe.json](https://github.com/flutter/engine/blob/5eb21d2706c0228ff16fed08857ef1d4dbb7da5c/ci/builders/mac_unopt_debug_no_rbe.json) to the standalone version: 1. Remove the drone_dimensions `device_type` and `os` and `$flutter/osx_sdk` property `sdk_version` since they are [already set via the "Mac" builder name](https://github.com/flutter/engine/blob/30bd6c9e861686581b6f0bca6834413559f6e0ef/.ci.yaml#L26-L37). Remove `mac_model` since there's no reason to specify hardware except for benchmarks afaik. `Macmini8,1` used to need to be specified to run on an Intel Mac before the `cpu` property was supported. 2. Remove `timeout` (default back to 30 minutes) since the timeout was added for the cold cache orchestrator timeouts (#55988). I repurposed non-bringup `Mac mac_unopt` to test the standalone config (and then reverted it) ([result](https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_unopt/10479/infra)). Here's the passing clangd test: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733402970006982913/+/u/test:_clangd/stdout I also renamed linux_unopt_debug_no_rbe.json to linux_clangd.json to match and added cas_archive (see #56014 (review)). Part of flutter/flutter#155041 Fixes flutter/flutter#157275 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This build does not come in under the default 30 minute timeout when the caches are cold and the bot_update steps take too long: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20mac_clangd/2928/overview
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…hestrator (flutter/engine#56014) "Orchestrator" builders are top-level builds that can perform some caching, kick off "drone" sub-builds, and then do things with those build artifacts like run tests, or "generators" that do work on those artifacts. See more details in https://flutter.dev/go/engine-build-definition-language. `Linux mac_clangd` is currently set up as an orchestrator builder, but it only kicks off one gn and one test that can be converted to a standalone build. `Linux mac_clangd` is confusingly named because the orchestrator is a Linux machine, but the drone is a Mac. Copy `Linux mac_clangd` into [`ci/builders/standalone`](https://github.com/flutter/engine/tree/c17390e606bf1ef5d64caf34c2e6d2fb5800fc1a/ci/builders/standalone) and reference it in a new `Mac clangd` build in `bringup`. Note since we want to rename the builder it can't replace `Linux mac_clangd` in the same commit. I will follow up and remove `Linux mac_clangd` once `Mac clangd` `bringup` is removed. Unfortunately that means we lose commit history. Differences from [ci/builders/mac_unopt_debug_no_rbe.json](https://github.com/flutter/engine/blob/9a7492dc886374eff8f44f47b1a8eb73bba6bc13/ci/builders/mac_unopt_debug_no_rbe.json) to the standalone version: 1. Remove the drone_dimensions `device_type` and `os` and `$flutter/osx_sdk` property `sdk_version` since they are [already set via the "Mac" builder name](https://github.com/flutter/engine/blob/c17390e606bf1ef5d64caf34c2e6d2fb5800fc1a/.ci.yaml#L26-L37). Remove `mac_model` since there's no reason to specify hardware except for benchmarks afaik. `Macmini8,1` used to need to be specified to run on an Intel Mac before the `cpu` property was supported. 2. Remove `timeout` (default back to 30 minutes) since the timeout was added for the cold cache orchestrator timeouts (flutter/engine#55988). I repurposed non-bringup `Mac mac_unopt` to test the standalone config (and then reverted it) ([result](https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_unopt/10479/infra)). Here's the passing clangd test: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733402970006982913/+/u/test:_clangd/stdout I also renamed linux_unopt_debug_no_rbe.json to linux_clangd.json to match and added cas_archive (see flutter/engine#56014 (review)). Part of flutter#155041 Fixes flutter#157275 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build does not come in under the default 30 minute timeout when the caches are cold and the bot_update steps take too long: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20mac_clangd/2928/overview