This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator #56014
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d371fdb
Add standalone 'Mac clang' builder to replace 'Linux mac_clangd' orch…
jmagman 5687dec
mac_unopt test
jmagman 99a9f78
empty
jmagman bf396ad
mac_unopt
jmagman 14c2804
mac_unopt
jmagman 4175dff
Review edits
jmagman 60abd00
use_cas
jmagman c7374ab
cas_archive
jmagman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"_comment": [ | ||
"This build is only used to generate compile_commands.json for clangd ", | ||
"and should not be used for any other purpose.", | ||
"", | ||
"Note the `flutter/tools/font_subset` target is only used because if no ", | ||
"targets are specified, the build will fail, and if an empty list of ", | ||
"targets are specified, all targets are built (wasteful/slow)" | ||
], | ||
"gn": [ | ||
"--runtime-mode", | ||
"debug", | ||
"--unoptimized", | ||
"--prebuilt-dart-sdk", | ||
"--no-lto", | ||
"--no-rbe", | ||
"--no-goma", | ||
"--xcode-symlinks", | ||
"--target-dir", | ||
"ci/mac_unopt_debug_no_rbe" | ||
], | ||
"name": "ci/mac_unopt_debug_no_rbe", | ||
"description": "Tests clangd on macOS.", | ||
"ninja": { | ||
"config": "ci/mac_unopt_debug_no_rbe", | ||
"targets": ["flutter/tools/font_subset"] | ||
}, | ||
"tests": [ | ||
{ | ||
"language": "dart", | ||
"name": "clangd", | ||
"script": "flutter/tools/clangd_check/bin/main.dart", | ||
"parameters": [ | ||
"--clangd=buildtools/mac-x64/clang/bin/clangd", | ||
"--compile-commands-dir=../out/ci/mac_unopt_debug_no_rbe" | ||
] | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zanderso should this be named
mac_unopt_debug_no_rbe.json
or something likemac_clangd.json
since the comment says not to use it for anything else?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That make sense to me. The name of the Linux one should probably also be changed.