Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove FlScrollingViewDelegate #56270

Conversation

robert-ancell
Copy link
Contributor

We can just contact the engine directly and test that by overriding the engine API.

We can just contact the engine directly and test that by overriding the engine API.
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@robert-ancell robert-ancell merged commit f32b77b into flutter:main Nov 5, 2024
29 checks passed
@robert-ancell robert-ancell deleted the linux-remove-scrolling-view-delegate branch November 5, 2024 21:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 6, 2024
…158218)

flutter/engine@e5e06c9...a3741d6

2024-11-05 [email protected] Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders (flutter/engine#56387)
2024-11-05 [email protected] iOS: Use standard Obj-C cflags for ios_test_flutter (flutter/engine#56384)
2024-11-05 [email protected] Remove unnecessary method for getting engine switches (command line). (flutter/engine#56265)
2024-11-05 [email protected] Remove FlScrollingViewDelegate (flutter/engine#56270)
2024-11-05 [email protected] fml: delete scoped_nsobject.h,mm (flutter/engine#56382)
2024-11-05 [email protected] Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (flutter/engine#56383)
2024-11-05 [email protected] [Impeller] Delete any remaining GL objects during destruction of the ReactorGLES (flutter/engine#56361)
2024-11-05 [email protected] [web] Switch all fonts to WOFF2 (non-split) (flutter/engine#56035)
2024-11-05 [email protected] [Impeller] exploit content context options' perfect hash function. (flutter/engine#56360)
2024-11-05 [email protected] Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (flutter/engine#56380)
2024-11-05 [email protected] Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (flutter/engine#56377)
2024-11-05 [email protected] [Impeller] match Skia's old VMA default block size. (flutter/engine#56368)
2024-11-05 [email protected] iOS: Refactor ShellTestPlatformViewMetal (flutter/engine#56370)
2024-11-05 [email protected] Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... (flutter/engine#56374)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from amgHXcqtplha to z1otZzn3yKuG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
We can just contact the engine directly and test that by overriding the
engine API.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants