This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Eliminate unnecessary use of NSClassFromString #56660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing `isKindOfClass` checks, we were occasionally looking up the class in question using `NSClassFromString()`, instead we now check against the class directly, which has the added benefit of being type-safe, and not succeptible to string typos. Moves the declaration of ForwardingGestureRecognizer and FlutterDelayingGestureRecognizer to the FlutterPlatfomViews_Internal.h header, which is non-public.
cbracken
changed the title
stuartmorgan-g
approved these changes
Nov 17, 2024
shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h
Show resolved
Hide resolved
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
…159057) flutter/engine@4878f1c...a63841d 2024-11-18 [email protected] iOS: Clean up @synthesize directives / ivars (flutter/engine#56665) 2024-11-17 [email protected] Roll Skia from 4708534db2e7 to 452208ce96aa (1 revision) (flutter/engine#56664) 2024-11-17 [email protected] iOS: Extract constant for CADisableMinimumFrameDurationOnPhone (flutter/engine#56659) 2024-11-17 [email protected] iOS: Eliminate unnecessary use of NSClassFromString (flutter/engine#56660) 2024-11-17 [email protected] iOS: Eliminate unnecessary bridged retain casts (flutter/engine#56662) 2024-11-17 [email protected] iOS,macOS: Fix string constant declarations (flutter/engine#56661) 2024-11-17 [email protected] iOS: Make FlutterViewController.engine a strong ref (flutter/engine#56663) 2024-11-17 [email protected] iOS: Clean up uses of string literal constants (flutter/engine#56658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…6660) When performing `isKindOfClass` checks, we were occasionally looking up the class in question using `NSClassFromString()`, instead we now check against the class directly, which has the added benefit of being type-safe, and not succeptible to string typos. Moves the declaration of ForwardingGestureRecognizer and FlutterDelayingGestureRecognizer to the FlutterPlatfomViews_Internal.h header, which is non-public. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing
isKindOfClasschecks, we were occasionally looking up the class in question usingNSClassFromString(), instead we now check against the class directly, which has the added benefit of being type-safe, and not succeptible to string typos.Moves the declaration of ForwardingGestureRecognizer and FlutterDelayingGestureRecognizer to the FlutterPlatfomViews_Internal.h header, which is non-public.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.