Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iOS: Make FlutterViewController.engine a strong ref #56663

Merged
merged 1 commit into from
Nov 17, 2024
Merged

iOS: Make FlutterViewController.engine a strong ref #56663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/darwin/ios/framework/Headers/FlutterViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ FLUTTER_DARWIN_EXPORT
* `FlutterViewController` is initialized with or a new `FlutterEngine` implicitly created if
* no engine was supplied during initialization.
*/
@property(weak, nonatomic, readonly) FlutterEngine* engine;
@property(nonatomic, readonly) FlutterEngine* engine;

/**
* The `FlutterBinaryMessenger` associated with this FlutterViewController (used for communicating
Expand Down
5 changes: 0 additions & 5 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ - (void)handleKeyboardAnimationCallbackWithTargetTime:(fml::TimePoint)targetTime
@end

@implementation FlutterViewController {
FlutterEngine* _engine;
flutter::ViewportMetrics _viewportMetrics;
MouseState _mouseState;
}
Expand Down Expand Up @@ -302,10 +301,6 @@ - (void)performCommonViewControllerInitialization {
[self setUpNotificationCenterObservers];
}

- (FlutterEngine*)engine {
return _engine;
}

- (void)setUpNotificationCenterObservers {
NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
[center addObserver:self
Expand Down