Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iOS,macOS: Enable ARC in flutter_cflags_objc[c] #56685

Merged
merged 1 commit into from
Nov 18, 2024
Merged

iOS,macOS: Enable ARC in flutter_cflags_objc[c] #56685

merged 1 commit into from
Nov 18, 2024

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 18, 2024 •
edited
Loading

Enables the -fobjc-arc compiler flag for Objective-C and Objective-C++ translation units.

Eliminates the flutter_cflags_objc[c]_arc settings, since they're now redundant.

All Obj-C/Obj-C++ code in our codebase has now been migrated to ARC.

Issue: flutter/flutter#137801

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • This wraps up a pretty long ARC of work.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
iOS,macOS: Enable ARC in flutter_cflags_objc[c]
320f2a5 
Enables the `-fobjc-arc` compiler flag for Objective-C and Objective-C++
translation units.

Eliminates the flutter_cflags_objc[c]_arc settings, since they're now
redundant.

All Obj-C/Obj-C++ code in our codebase has now been migrated to ARC.

Issue: flutter/flutter#137801
jmagman
jmagman approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!!!

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2024
@cbracken cbracken merged commit e1a38ed into flutter:main Nov 18, 2024
29 checks passed
@cbracken cbracken deleted the arc-gn-config-orig branch November 18, 2024 21:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2024
@engine-flutter-autoroll
e1a38ed7c iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/en…
7135e2f 
…gine#56685)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2024
@engine-flutter-autoroll
e1a38ed7c iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/en…
319eb1b 
…gine#56685)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 878f593802e1 to 7643ef10c25f (10 revisions) (#…
f2d8069 
…159111)

flutter/engine@878f593...7643ef1

2024-11-18 [email protected] iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 [email protected] [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 [email protected] Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 [email protected] Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 [email protected] Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 [email protected] iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 [email protected] Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 [email protected] Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 [email protected] Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 [email protected] Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
e1a38ed7c iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/en…
ea280cc 
…gine#56685)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 878f593802e1 to c9a965c4e5e6 (11 revisions) (#…
91c7b81 
…159113)

flutter/engine@878f593...c9a965c

2024-11-18 [email protected] Roll Dart SDK from
625e0a9cb67a to 05d58364e92f (1 revision) (flutter/engine#56688)
2024-11-18 [email protected] iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 [email protected] [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 [email protected] Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 [email protected] Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 [email protected] Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 [email protected] iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 [email protected] Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 [email protected] Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 [email protected] Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 [email protected] Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
e1a38ed7c iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/en…
daed50b 
…gine#56685)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 878f593802e1 to 10dc07bf548f (12 revisions) (#…
6ed9327 
…159116)

flutter/engine@878f593...10dc07b

2024-11-18 [email protected] Update emulator definitions version to
latest available from chrome infra (flutter/engine#56313)
2024-11-18 [email protected] Roll Dart SDK from
625e0a9cb67a to 05d58364e92f (1 revision) (flutter/engine#56688)
2024-11-18 [email protected] iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 [email protected] [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 [email protected] Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 [email protected] Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 [email protected] Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 [email protected] iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 [email protected] Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 [email protected] Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 [email protected] Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 [email protected] Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
e1a38ed7c iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/en…
f81ae68 
…gine#56685)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 878f593802e1 to c1b0e18a70b3 (13 revisions) (#…
4426413 
…159118)

flutter/engine@878f593...c1b0e18

2024-11-19 [email protected] [Impeller] use sync fence for image
uploads. (flutter/engine#56609)
2024-11-18 [email protected] Update emulator definitions version to
latest available from chrome infra (flutter/engine#56313)
2024-11-18 [email protected] Roll Dart SDK from
625e0a9cb67a to 05d58364e92f (1 revision) (flutter/engine#56688)
2024-11-18 [email protected] iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 [email protected] [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 [email protected] Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 [email protected] Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 [email protected] Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 [email protected] iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 [email protected] Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 [email protected] Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 [email protected] Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 [email protected] Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
@cbracken
iOS,macOS: Enable ARC in flutter_cflags_objc[c] (flutter/engine#56685)
bcbcb66 
Enables the `-fobjc-arc` compiler flag for Objective-C and Objective-C++
translation units.

Eliminates the flutter_cflags_objc[c]_arc settings, since they're now
redundant.

All Obj-C/Obj-C++ code in our codebase has now been migrated to ARC.

Issue: flutter#137801
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jmagman jmagman jmagman approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

Assignees
No one assigned
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbracken @chinmaygarde @jmagman