Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Start with a smaller memory allocation for CanvasKit #56900

Merged
auto-submit merged 2 commits into from
Dec 4, 2024
Merged

[web] Start with a smaller memory allocation for CanvasKit #56900

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090e8bc
[web] Start with a smaller memory allocation for CanvasKit
mdebbar Dec 2, 2024
40224c7
expand memory by doubling
mdebbar Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skia/modules/canvaskit/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ canvaskit_wasm_lib("canvaskit") {
"-sFILESYSTEM=0",
"-sMODULARIZE",
"-sNO_EXIT_RUNTIME=1",
"-sINITIAL_MEMORY=128MB",
"-sINITIAL_MEMORY=64MB",
Copy link
Contributor

@yjbanov yjbanov Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if should try 32MB. Worst case it will cost one extra 32 => 64 reallocation, and that's not too big.

Copy link
Contributor

@jonahwilliams jonahwilliams Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this memory allocation size include textures and the onscreen render target? For reference, the initial heap size for just CPU allocations we use for Android is 4MB

Copy link
Contributor

@jonahwilliams jonahwilliams Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is for the entire wasm heap? maybe 4MB isn't quite enough...

Copy link
Contributor

@yjbanov yjbanov Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I imagine (hope?) that most textures and render targets bypass the wasm heap.

"-sWASM",
"-sSTRICT=1",
]
Expand Down
Loading