Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix common asserts in animation API. #592

Merged
merged 1 commit into from
Aug 13, 2015
Merged

Fix common asserts in animation API. #592

merged 1 commit into from
Aug 13, 2015

Conversation

mpcomplete
Copy link
Contributor

  1. We would assert if you tried to start an animation from within an
    animation status callback. This is a common pattern, so I fixed this
    assert (in Ticker._tick).
  2. We would assert for animations with duration under a millisecond.
    Fixed.

Also removed the workarounds assocated with #1.

1. We would assert if you tried to start an animation from within an
animation status callback. This is a common pattern, so I fixed this
assert (in Ticker._tick).
2. We would assert for animations with duration under a millisecond.
Fixed.

Also removed the workarounds assocated with #1.
scheduleMicrotask(() {
navigator.pushState(this, (_) => _performance.reverse());
});
navigator.pushState(this, (_) => _performance.reverse());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\\ooooo/////

@abarth
Copy link
Contributor

abarth commented Aug 13, 2015

LGTM

mpcomplete added a commit that referenced this pull request Aug 13, 2015
Fix common asserts in animation API.
@mpcomplete mpcomplete merged commit 761fd54 into flutter:master Aug 13, 2015
@mpcomplete mpcomplete deleted the animation.asserts branch August 13, 2015 17:55
itekdev pushed a commit to itekdev/flutter-engine0 that referenced this pull request May 1, 2023
…er#592)

* Add dependabot, which will check for updates to github actions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants