This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix common asserts in animation API. #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We would assert if you tried to start an animation from within an animation status callback. This is a common pattern, so I fixed this assert (in Ticker._tick). 2. We would assert for animations with duration under a millisecond. Fixed. Also removed the workarounds assocated with #1.
| scheduleMicrotask(() { | ||
| navigator.pushState(this, (_) => _performance.reverse()); | ||
| }); | ||
| navigator.pushState(this, (_) => _performance.reverse()); |
|
LGTM |
mpcomplete
added a commit
that referenced
this pull request
Aug 13, 2015
Fix common asserts in animation API.
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
…er#592) * Add dependabot, which will check for updates to github actions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animation status callback. This is a common pattern, so I fixed this
assert (in Ticker._tick).
Fixed.
Also removed the workarounds assocated with #1.