Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Raise errors on non-zero exits while creating artifacts on the bots. #6424

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Raise errors on non-zero exits while creating artifacts on the bots. #6424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sky/tools/create_ios_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def main():

linker_out = os.path.join(fat_framework, 'Flutter')

subprocess.call([
subprocess.check_call([
'lipo',
arm64_dylib,
armv7_dylib,
Expand All @@ -72,14 +72,14 @@ def main():

if args.dsym:
dsym_out = os.path.splitext(fat_framework)[0] + '.dSYM'
subprocess.call(['dsymutil', '-o', dsym_out, linker_out])
subprocess.check_call(['dsymutil', '-o', dsym_out, linker_out])

if args.strip:
# copy unstripped
unstripped_out = os.path.join(args.dst, 'Flutter.unstripped')
shutil.copyfile(linker_out, unstripped_out)

subprocess.call(["strip", "-x", "-S", linker_out])
subprocess.check_call(["strip", "-x", "-S", linker_out])


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion sky/tools/create_macos_gen_snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def main():
print 'Cannot find i386 (armv7) gen_snapshot at', armv7_gen_snapshot
return 1

subprocess.call([
subprocess.check_call([
'lipo',
arm64_gen_snapshot,
armv7_gen_snapshot,
Expand Down