Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert height #6477

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Revert height #6477

merged 2 commits into from
Oct 9, 2018

Conversation

liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Oct 9, 2018

This should fix our Google3 roll.

@liyuqian liyuqian requested a review from GaryQian October 9, 2018 17:30
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liyuqian liyuqian merged commit bf37789 into flutter:master Oct 9, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2018
flutter/engine@289c6b1...bf37789

git log 289c6b1..bf37789 --no-merges --oneline
bf37789 Revert height (flutter/engine#6477)
ec103ad Roll src/third_party/skia a41a74ac7994..ef85d19100b1 (11 commits) (flutter/engine#6476)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
liyuqian pushed a commit to flutter/flutter that referenced this pull request Oct 9, 2018
flutter/engine@289c6b1...bf37789

git log 289c6b1..bf37789 --no-merges --oneline
bf37789 Revert height (flutter/engine#6477)
ec103ad Roll src/third_party/skia a41a74ac7994..ef85d19100b1 (11 commits) (flutter/engine#6476)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@liyuqian liyuqian deleted the revert_height branch November 12, 2018 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants