Skip to content

Commit 9fef30b

Browse files
authored
update and (re)enable assisted code reviews (#8816)
Updates config to be inline with flutter's (except where noted) and enables reviews on pull requests. --- A sample review provoked by a bogus `TODO` and system out. <img width="590" height="616" alt="image" src="https://github.com/user-attachments/assets/69e96f1a-9ac8-4afb-81e0-83d1d4eb6c4b" /> Note how it's reading from our style guide and recommending our bespoke logger. Closes: #8815. --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 600f041 commit 9fef30b

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

.gemini/config.yaml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,25 @@
1-
# These are all defaults for now. Descriptions for these settings: https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#config.yaml-schema
1+
# Based on Flutter config: https://github.com/flutter/flutter/blob/master/.gemini/config.yaml
2+
#
3+
# Schema: https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github#config.yaml-schema
4+
5+
# No poetry in summaries (DEFAULT).
26
have_fun: false
7+
38
code_review:
9+
# (DEFAULT)
410
disable: false
11+
# LOW, MEDIUM, HIGH or CRITICAL
512
comment_severity_threshold: MEDIUM
13+
# -1 is unlimited (DEFAULT)
614
max_review_comments: -1
715
pull_request_opened:
16+
# (DEFAULT)
817
help: false
18+
# These tend to be verbose, and since we expect PR authors to clearly
19+
# describe their PRs this would be at best duplicative.
920
summary: false
10-
code_review: false
21+
code_review: true
22+
# (DEFAULT) -- Note that this is disabled for flutter
1123
include_drafts: true
1224
ignore_patterns: []
1325

0 commit comments

Comments
 (0)