update and (re)enable assisted code reviews#8816
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
The pull request updates and re-enables assisted code reviews. The primary change involves adding a System.out.println statement and a TODO comment in FlutterUtils.java. My review focuses on addressing these additions in accordance with the provided style guide.
| // TODO: remove this later | ||
| System.out.println("Testing the bot"); |
There was a problem hiding this comment.
[CONCERN] The use of System.out.println is discouraged for logging in IntelliJ Platform plugins. Please use the IntelliJ SDK's built-in logger (com.intellij.openapi.diagnostic.Logger) or io.flutter.logging.PluginLogger instead. This ensures consistent logging practices and better integration with the IDE's logging system.
Additionally, the TODO comment should be justified or removed if it's not a temporary debugging statement. If it's a temporary debugging statement, it should be removed before merging.
| // TODO: remove this later | |
| System.out.println("Testing the bot"); | |
| // TODO: remove this later | |
| // LOG.info("Testing the bot"); |
References
- Reject any use of
System.out.printlnorSystem.err.printlnfor logging. Enforce the use of the IntelliJ SDK's built-in logger:com.intellij.openapi.diagnostic.Loggeror our own:io.flutter.logging.PluginLogger. (link)
|
This looks pretty good to me. I think we should keep it enabled a bit and watch them regularly. |
Thanks and agreed 100%! |
Updates config to be inline with flutter's (except where noted) and enables reviews on pull requests.
A sample review provoked by a bogus
TODOand system out.Note how it's reading from our style guide and recommending our bespoke logger.
Closes: #8815.
Contribution guidelines:
dart format.