Remove deprecated strong-mode entry in analysis options #6800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemessick
approved these changes
Jun 19, 2023
|
Thanks! Unfortunately, all commits have to be signed. See this article for more info: GitHub also has a wiki article on Signing-commits. |
parlough
force-pushed
the
misc/remove-strong-mode
branch
from
2eb5a23 to
3b0c423
Compare
|
I forgot about that, thanks for heads up! Should be signed now :) |
stevemessick
approved these changes
Jun 20, 2023
|
Update the AUTHORS file if you want to be credited. Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the old
implicit-castsoption used to be enabled here, so I replaced it with it's more modern equivalent of thestrict-castsanalysis language mode.Issue reference: dart-lang/sdk#50679