Skip to content

[CQ] limit internal XDebugSessionImpl dependence; remove dead code#8206

Merged
pq merged 3 commits into
flutter:mainfrom
pq:cq_XDebugSessionImpl
Aug 28, 2025
Merged

[CQ] limit internal XDebugSessionImpl dependence; remove dead code#8206
pq merged 3 commits into
flutter:mainfrom
pq:cq_XDebugSessionImpl

Conversation

@pq
Copy link
Copy Markdown
Collaborator

@pq pq commented May 20, 2025

🤫 Limits XDebugSessionImpl dependence (silencing two internal API access inspections); adding a note explaining our usage
🧹 Removes VmServiceWrapper dead code


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren May 20, 2025 18:20
Copy link
Copy Markdown
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but do test to validate that this code works back to the Dart 3.0 debugger (and associated Flutter SDK)

@Piinks
Copy link
Copy Markdown
Contributor

Piinks commented Jul 23, 2025

Hey @pq, is this something you are still working on?

@pq
Copy link
Copy Markdown
Collaborator Author

pq commented Jul 24, 2025

Hey @Piinks! It is, yeah. I have some merge conflicts to fix up and some testing... Sorry to drag it out!

pq added 2 commits August 28, 2025 14:47
# Conflicts:
#	src/io/flutter/vmService/VmServiceWrapper.java
@pq pq merged commit ba7b436 into flutter:main Aug 28, 2025
7 checks passed
@pq pq deleted the cq_XDebugSessionImpl branch August 28, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants