Skip to content

[logging] Change JX Browser file management to plugin logger #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helin24 merged 1 commit into from
Jul 8, 2025
Merged

[logging] Change JX Browser file management to plugin logger #8320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions flutter-idea/src/io/flutter/jxbrowser/JxBrowserManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.intellij.util.download.FileDownloader;
import com.teamdev.jxbrowser.browser.UnsupportedRenderingModeException;
import com.teamdev.jxbrowser.engine.RenderingMode;
import io.flutter.logging.PluginLogger;
import io.flutter.settings.FlutterSettings;
import io.flutter.utils.FileUtils;
import io.flutter.utils.JxBrowserUtils;
Expand Down Expand Up @@ -81,7 +82,7 @@ else if (Objects.equals(info.getMajorVersion(), "2020")) {
@NotNull
private static final AtomicBoolean listeningForSetting = new AtomicBoolean(false);
@NotNull
private static final Logger LOG = Logger.getInstance(JxBrowserManager.class);
private static final Logger LOG = PluginLogger.createLogger(JxBrowserManager.class);
@NotNull
public static CompletableFuture<JxBrowserStatus> installation = new CompletableFuture<>();
@NotNull
Expand Down Expand Up @@ -261,7 +262,7 @@ public void setUp(@NotNull String projectName) {
assert fileName != null;
final String filePath = getFilePath(fileName);
if (!fileUtils.deleteFile(filePath)) {
LOG.info(projectName + ": Existing file could not be deleted - " + filePath);
LOG.info(projectName + ": Existing file could not be deleted - " + fileName);
}
}
downloadJxBrowser(fileNames);
Expand Down Expand Up @@ -311,7 +312,7 @@ public void run(@NotNull ProgressIndicator indicator) {
ContainerUtil.getFirstItem(downloader.download(new File(DOWNLOAD_PATH)));
final File file = download != null ? download.first : null;
if (file != null) {
LOG.info(project.getName() + ": JxBrowser file downloaded: " + file.getAbsolutePath());
LOG.info(project.getName() + ": JxBrowser file downloaded: " + file.getName());
}
}

Expand Down Expand Up @@ -344,11 +345,11 @@ private void loadClasses(@NotNull String @NotNull [] fileNames) {
fileUtils.loadPaths(this.getClass().getClassLoader(), paths);
}
catch (Exception ex) {
LOG.info("Failed to load JxBrowser file", ex);
LOG.info("Failed to load JxBrowser paths");
setStatusFailed(new InstallationFailedReason(FailureType.CLASS_LOAD_FAILED));
return;
}
LOG.info("Loaded JxBrowser files successfully: " + paths);
LOG.info("Loaded JxBrowser files successfully");

try {
final Class<?> clazz = Class.forName("com.teamdev.jxbrowser.browser.UnsupportedRenderingModeException");
Expand Down