[logging] Use separate log for FlutterCommand#8339
Merged
Conversation
jwren
approved these changes
Jul 16, 2025
Collaborator
|
Cool! I wonder if this is something we should run by @anderdobo or @mit-mit? Do we need any extra messaging to make sure folks know not to have this enabled if filenames are sensitive and they're sharing logs with us? |
Member
Author
|
Before this change we were logging these paths in |
Member
Author
|
But regardless, if any of you have opinions of what we can/should log in local files, please let me know. I started a doc on this but don't have much content at the moment. |
Collaborator
|
SGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option (default off) to record full file paths in logs. Originally I was thinking that we shouldn't record any file paths, but it seems reasonable to have them sometimes for debugging setup issues since these are recorded on a user's machine rather than to somewhere centralized that we receive by default.