[analytics] introduces constants#8601
Merged
Merged
Conversation
helin24
approved these changes
Nov 4, 2025
| * "MainToolbar", "EditorPopup", "GoToAction", etc). | ||
| */ | ||
| @JvmField | ||
| val PLACE = StringValue("place") |
Member
There was a problem hiding this comment.
I might expect these to be namespaced, e.g. ACTION_PLACE or AnalyticsConstants.Actions.PLACE
Collaborator
Author
There was a problem hiding this comment.
My sense is that's unneeded since action-ness is encoded in the TYPE property already? Anyway, for sure, let's talk about it and do a full audit before we start actually capturing any data. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #8597. Introduces constants.
Contribution guidelines:
dart format.