Refactor FlutterStudioProjectOpenProcessor to improve openProjectAsync robustness with a project fallback mechanism, extracting helper methods, and adding a unit test.#8681
Merged
Conversation
…sync` robustness with a project fallback mechanism, extracting helper methods, and adding a unit test. Follow up on: flutter#8629 Related issue: flutter#8661
helin24
approved these changes
Jan 6, 2026
pq
reviewed
Jan 6, 2026
| if (newProject == null || newProject.isDisposed) { | ||
| return newProject | ||
| // Fallback to the original project if re-lookup fails. | ||
| if (project != null && !project.isDisposed) { |
Collaborator
There was a problem hiding this comment.
Do we know why this might happen?
Member
Author
There was a problem hiding this comment.
No unfortunately, we don't have steps to reproduce it. Just defensive programming :)
Collaborator
There was a problem hiding this comment.
Consider adding logging? it'd be great to know if this condition occurs and if it resolves issues folks are hitting in the wild. (We might consider analytics ultimately too.)
pq
reviewed
Jan 16, 2026
| @@ -0,0 +1,60 @@ | |||
| package io.flutter.editor | |||
Collaborator
There was a problem hiding this comment.
Whoops... This never got a copyright header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on: #8629
Related issue: #8661