Add test asserting display name setter is accessible on current IntelliJ build#8809
Merged
Merged
Conversation
…liJ build Extracts the reflection lookup into a @VisibleForTesting getDisplaySetter() method and adds a test asserting it returns non-null. Serves as a regression guard: if JetBrains removes or renames setDisplayName in a future build, the test will fail loudly rather than the feature silently breaking for users. Follow-up to flutter#8796.
1 task
Collaborator
|
This is fantastic and a great reference point for #8806 too. Thanks for following up and moving this along! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8796.
Extracts the reflection lookup into a
@VisibleForTesting getDisplaySetter()method and adds a test asserting it returns non-null. This serves as a regression guard: if JetBrains removes or renamessetDisplayNamein a future build, the test will fail loudly rather than the feature silently breaking for users (which was the original failure mode in #8795).Verified locally by running the test against the real SDK (passes), then temporarily corrupting the method name to
setDisplayName_doesNotExist(fails with the expected assertion message).I've reviewed the contributor guide and applied the relevant portions to this PR.