Skip to content

Make color recognition more specific #8824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helin24 merged 4 commits into from
Feb 25, 2026
Merged

Make color recognition more specific #8824

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb1c96c
Make color recognition more specific
helin24 Feb 24, 2026
f03d70a
Update src/io/flutter/editor/FlutterColorProvider.java
helin24 Feb 24, 2026
e7169be
Update src/io/flutter/editor/FlutterColorProvider.java
helin24 Feb 24, 2026
fcfa50d
Merge branch 'main' into color
pq Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/io/flutter/editor/FlutterColorProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ public Color getColorFrom(@NotNull PsiElement element) {

if (parent.getNode().getElementType() == DartTokenTypes.ARRAY_ACCESS_EXPRESSION) {
// Colors.blue[200]
if (!refExpr.getFirstChild().getText().equals("Colors") && !refExpr.getFirstChild().getText().equals("CupertinoColors")) {
return null;
}
if (name.equals(refExpr.getFirstChild().getText()) && refExpr.getChildren().length > 1) {
// Avoid duplicate resolves.
return null;
Expand Down Expand Up @@ -116,7 +119,7 @@ else if (parent.getNode().getElementType() == DartTokenTypes.SIMPLE_TYPE) {
// name.equals(refExpr.getFirstChild().getText()) -> Colors.blue
final PsiElement idNode = refExpr.getFirstChild();
if (idNode == null) return null;
if (name.equals(idNode.getText())) {
if ((name.equals("Colors") || name.equals("CupertinoColors")) && name.equals(idNode.getText())) {
final PsiElement selectorNode = refExpr.getLastChild();
if (selectorNode == null) return null;
final String code = AstBufferUtil.getTextSkippingWhitespaceComments(selectorNode.getNode());
Expand Down
Loading