Skip to content

Update CONTRIBUTING.md #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cj-radcliff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update CONTRIBUTING.md #8852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f815a
Update CONTRIBUTING.md
cj-radcliff Mar 13, 2026
7980d3e
Merge branch 'main' into update_contributing_ai
cj-radcliff May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,28 @@ before any of your contributions with code get merged into the repo.
If you've never submitted code before, you must add your (or your organization's)
name and contact info to the [AUTHORS](AUTHORS) file.

## AI Contribution Guidelines

PRs prepared using AI tools must follow these requirements:

1. You must review all AI-generated code before uploading it for review, and before requesting
re-review of any updates to the uploaded change.
* You are responsible for ensuring that code you submit meets coding standards.
* Unmodified AI output generally does _not_ meet those standards.
2. You must ensure that uploaded code compiles and passes at least the tests you have yourself
added as part of the change.
Comment on lines +47 to +48
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The requirement for testing could be stronger. Stating that the code must pass 'at least the tests you have yourself added' might be misinterpreted as allowing regressions in existing tests. To avoid ambiguity, it would be better to require that all relevant tests pass.

Suggested change
2. You must ensure that uploaded code compiles and passes at least the tests you have yourself
added as part of the change.
2. You must ensure that uploaded code compiles and passes all relevant tests.

Copy link
Copy Markdown
Collaborator Author

@cj-radcliff cj-radcliff Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pq what do you say?

Copy link
Copy Markdown
Collaborator

@pq pq Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love where this is going. Without digging too deep, I wonder if we couldn't all converge on what @elliette landed for devtools w/ flutter/devtools#9700? It'd be nice to have one consistent set of guidance.

3. You must understand and be able to discuss the code you are uploading for review.
* Non-trivial changes require discussion and iteration during review. If you do not understand the
code, you cannot meaningfully respond to review feedback.
* In our experience, simply feeding review feedback into an AI agent and uncritically reposting
its output will not lead to a constructive review.
4. You must verify the accuracy of any AI-generated text you include in the change description or
review discussion comments.
* If an AI provides you incorrect information, it is just hallucinating; if you choose to paste
that text into GitHub, you are misrepresenting your change to your reviewer.
* In particular, do not tell a reviewer that you have addressed their feedback just because
AI output says so. It is your responsibility to make sure that review feedback has actually
been addressed.
## Getting started

1. Install Flutter SDK from [Flutter SDK download](https://flutter.dev/docs/get-started/install) or
Expand Down
Loading