Skip to content

Add deep links tool window integration test#8855

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
helin24:tool-window-test
Mar 19, 2026
Merged

Add deep links tool window integration test#8855
auto-submit[bot] merged 5 commits into
flutter:mainfrom
helin24:tool-window-test

Conversation

@helin24
Copy link
Copy Markdown
Member

@helin24 helin24 commented Mar 17, 2026

This opens a project and checks that the deep links panel can be opened (since it does not require a running app).

I'm able to run on mac with ./gradlew integration --tests "io.flutter.integrationTest.DeepLinksToolWindowTest". Sometimes I've gotten weird errors when I don't run ./gradlew clean first, but not always.

Part of #7959

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an integration test for the Deep Links tool window. The test creates a new Flutter project, opens it in the IDE, and verifies that the Deep Links tool window can be opened and contains a browser component.

My review has identified a few areas for improvement:

  • The test has some state management and cleanup issues that could affect test isolation and cause resource leaks.
  • The test uses println for logging, which is against the repository's style guide.
  • There are some minor import cleanup opportunities.

Please see the detailed comments for suggestions.

Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
@helin24
Copy link
Copy Markdown
Member Author

helin24 commented Mar 17, 2026

@gemini-code-assist can you review again?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new integration test for the Deep Links tool window. The test correctly creates a project, opens the IDE, and verifies that the tool window can be opened. My feedback includes suggestions to replace println calls with a proper logger as required by the style guide, and to use a predefined constant for the tool window ID to improve maintainability.

Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
…ndowTest.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@helin24 helin24 requested a review from pq March 17, 2026 18:54
Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
Comment thread testSrc/integration/io/flutter/integrationTest/DeepLinksToolWindowTest.kt Outdated
@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Mar 19, 2026
@auto-submit auto-submit Bot merged commit 3514768 into flutter:main Mar 19, 2026
8 checks passed
@helin24 helin24 deleted the tool-window-test branch March 19, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants