Skip to content

[build] inline dev-build upload in deploy.sh#8868

Merged
pq merged 2 commits into
flutter:mainfrom
pq:build_deployDevRefactor
Mar 25, 2026
Merged

[build] inline dev-build upload in deploy.sh#8868
pq merged 2 commits into
flutter:mainfrom
pq:build_deployDevRefactor

Conversation

@pq
Copy link
Copy Markdown
Collaborator

@pq pq commented Mar 25, 2026

Removes the call to plugin..dart deploy in favor of a bash implementation inline.

Fixes: #8866 .


Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tool/kokoro/deploy.sh script to directly upload the plugin zip file to the JetBrains Marketplace using curl, replacing the previous ./bin/plugin deploy command. The script now includes logic to retrieve an authentication token and verify the existence of the zip file before upload. A review comment highlighted that the new curl command lacks proper error handling and has a robustness issue due to an unquoted variable, recommending the use of the --fail flag and quoting the $ZIP_FILE variable.

Comment thread tool/kokoro/deploy.sh Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@pq pq requested a review from helin24 March 25, 2026 03:18
Copy link
Copy Markdown
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 ... wow that is a small script

@pq pq merged commit f98a22a into flutter:main Mar 25, 2026
8 checks passed
@pq pq deleted the build_deployDevRefactor branch March 25, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build] convert kokoro deploy.sh to pure bash

2 participants