-
Notifications
You must be signed in to change notification settings - Fork 343
Syncing with main branch #8872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing with main branch #8872
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright 2026 The Chromium Authors. All rights reserved. | ||
| * Use of this source code is governed by a BSD-style license that can be | ||
| * found in the LICENSE file. | ||
| */ | ||
| package io.flutter.run.common; | ||
|
|
||
| import com.intellij.psi.PsiElement; | ||
| import com.intellij.psi.impl.source.tree.LeafPsiElement; | ||
| import com.jetbrains.lang.dart.psi.DartCallExpression; | ||
| import io.flutter.AbstractDartElementTest; | ||
| import io.flutter.dart.DartSyntax; | ||
| import io.flutter.run.test.TestConfigUtils; | ||
| import org.junit.Test; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
| public class CommonTestConfigUtilsTest extends AbstractDartElementTest { | ||
| @Test | ||
| public void extractTestNameShouldNotEscapeNonAscii() throws Exception { | ||
| run(() -> { | ||
| final PsiElement testKeyword = setUpDartElement( | ||
| "main() { test('テスト', () {}); }", "test", LeafPsiElement.class); | ||
| final DartCallExpression call = | ||
| DartSyntax.findEnclosingFunctionCall(testKeyword, "test"); | ||
| assertNotNull(call); | ||
|
|
||
| final String name = TestConfigUtils.getInstance().extractTestName(call); | ||
| assertEquals("テスト", name); | ||
| }); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,26 @@ echo "kokoro build start" | |||||
| echo "kokoro build finished" | ||||||
|
|
||||||
| echo "kokoro deploy start" | ||||||
| ./bin/plugin deploy --channel=dev | ||||||
|
|
||||||
| KOKORO_TOKEN_FILE="${KOKORO_KEYSTORE_DIR}/${FLUTTER_KEYSTORE_ID}_${FLUTTER_KEYSTORE_NAME}" | ||||||
| if [ ! -f "$KOKORO_TOKEN_FILE" ]; then | ||||||
| echo "Error: Keystore token file not found at $KOKORO_TOKEN_FILE" | ||||||
| exit 1 | ||||||
| fi | ||||||
| TOKEN=$(cat "$KOKORO_TOKEN_FILE") | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
|
|
||||||
| ZIP_FILE="build/distributions/flutter-intellij-kokoro.zip" | ||||||
| if [ ! -f "$ZIP_FILE" ]; then | ||||||
| echo "Error: Zip file not found at $ZIP_FILE" | ||||||
| exit 1 | ||||||
| fi | ||||||
|
|
||||||
| echo "Uploading $ZIP_FILE to JetBrains Marketplace..." | ||||||
| curl -if --fail \ | ||||||
| --header "Authorization: Bearer $TOKEN" \ | ||||||
| -F pluginId=9212 \ | ||||||
| -F file=@"$ZIP_FILE" \ | ||||||
| -F channel=dev \ | ||||||
| https://plugins.jetbrains.com/plugin/uploadPlugin | ||||||
|
|
||||||
| echo "kokoro deploy finished" | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
catchblock logic is also present inEmbeddedJxBrowser.close(). According to the repository style guide (Rule #70, DRY), duplicated code should be avoided. Please consider extracting this conditional logging logic into a shared utility method to improve maintainability and reduce duplication.