Skip to content

Added missing platforms and targets to Build menu#8875

Merged
helin24 merged 4 commits into
flutter:mainfrom
ThexXTURBOXx:main
May 4, 2026
Merged

Added missing platforms and targets to Build menu#8875
helin24 merged 4 commits into
flutter:mainfrom
ThexXTURBOXx:main

Conversation

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor

@ThexXTURBOXx ThexXTURBOXx commented Mar 27, 2026

The build menu is currently lacking a few targets. This PR adds them.

Fixes #8943


Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new build targets (Assets Bundle, Linux, macOS, and Windows) to the Flutter Build menu. The review feedback identifies missing logic in the new action classes, specifically the need to call the superclass update method and verify the presence of platform-specific directories. It also suggests adding linter suppression tags in the plugin configuration for consistency.

Comment thread src/io/flutter/actions/FlutterBuildActionGroup.java
Comment thread resources/META-INF/plugin.xml
Comment thread resources/META-INF/plugin.xml
@helin24
Copy link
Copy Markdown
Member

helin24 commented Apr 30, 2026

Thanks for your contribution! And sorry about the delay looking into this. We haven't thought about this much, so we will need some more information on the need for this change. An issue could be helpful - could you document how this impacts your workflow?

Regarding the change, is this a simple wrapper around flutter tools? Should these options be available for all build types or does it depend on what's enabled for the project?

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor Author

ThexXTURBOXx commented May 1, 2026

This PR is not about adding something new, but rather about consistency:
The build menu already exists, but does not contain every available platform.
One would expect it to contain all the platforms that Flutter supports - and hence enabling one-click-builds from within the IDE.

This how it currently looks (on Windows):
grafik

"Build iOS" is in the menu, but is disabled since I am on Windows. On macOS, it would be enabled and clickable.
I just added the other supported platforms to this menu and disabled them if they are not available on the current platform (e.g., macOS is only available on macOS and Linux is only available on Linux).

Disabling certain platforms if the current project does not have the specific required platform code is out of the scope for this PR - that would be a good topic for another PR, though!

Edit: Opened an issue: #8943

Copy link
Copy Markdown
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the issue and the additional details! I think this is a good change and code LGTM. I will leave it for @pq to look over and merge.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Helin Shiah <helinx@google.com>
Copy link
Copy Markdown
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@pq pq added the kokoro:run Triggers a Kokoro build (required for PRs submitted by members outside flutter). label May 1, 2026
@kokoro-team kokoro-team removed the kokoro:run Triggers a Kokoro build (required for PRs submitted by members outside flutter). label May 1, 2026
@helin24 helin24 merged commit dc90f5d into flutter:main May 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build menu does not contain every platform

4 participants