Added missing platforms and targets to Build menu#8875
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds new build targets (Assets Bundle, Linux, macOS, and Windows) to the Flutter Build menu. The review feedback identifies missing logic in the new action classes, specifically the need to call the superclass update method and verify the presence of platform-specific directories. It also suggests adding linter suppression tags in the plugin configuration for consistency.
|
Thanks for your contribution! And sorry about the delay looking into this. We haven't thought about this much, so we will need some more information on the need for this change. An issue could be helpful - could you document how this impacts your workflow? Regarding the change, is this a simple wrapper around flutter tools? Should these options be available for all build types or does it depend on what's enabled for the project? |
|
This PR is not about adding something new, but rather about consistency: This how it currently looks (on Windows): "Build iOS" is in the menu, but is disabled since I am on Windows. On macOS, it would be enabled and clickable. Disabling certain platforms if the current project does not have the specific required platform code is out of the scope for this PR - that would be a good topic for another PR, though! Edit: Opened an issue: #8943 |
Co-authored-by: Helin Shiah <helinx@google.com>

The build menu is currently lacking a few targets. This PR adds them.
Fixes #8943
Review the contribution guidelines below:
AUTHORSfile.CHANGELOG.mdif appropriate.Contribution guidelines:
our contributor guide and
the Flutter organization contributor guide
for general expectations for PRs.
dart format.practices (discussion).