Skip to content

Revert "Fix IntelliJ IDEA project open hang by removing FlutterProjec…#8884

Merged
helin24 merged 1 commit into
flutter:mainfrom
helin24:revert-idea
Apr 2, 2026
Merged

Revert "Fix IntelliJ IDEA project open hang by removing FlutterProjec…#8884
helin24 merged 1 commit into
flutter:mainfrom
helin24:revert-idea

Conversation

@helin24
Copy link
Copy Markdown
Member

@helin24 helin24 commented Apr 2, 2026

…tOpenProcessor (#8846)"

This reverts commit 4681015.

The problem is seeing the open project dialog (the one below) twice upon creating a new project.
Screenshot 2026-04-01 at 8 59 27 PM

@helin24 helin24 requested a review from pq April 2, 2026 04:00
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-introduces the FlutterProjectOpenProcessor in Kotlin to manage project opening and module configuration, replacing the previous implementation in FlutterInitializer. The review highlights a performance issue where multiple project reloads are triggered within a loop and a potential race condition caused by asynchronous configuration that deviates from the documentation. Additionally, it is recommended to use idiomatic Kotlin collection functions instead of Java Streams for better readability.

Comment thread src/io/flutter/project/FlutterProjectOpenProcessor.kt
Comment thread src/io/flutter/project/FlutterProjectOpenProcessor.kt
Comment thread src/io/flutter/project/FlutterProjectOpenProcessor.kt
Copy link
Copy Markdown
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@helin24 helin24 merged commit e5c96f8 into flutter:main Apr 2, 2026
8 checks passed
@helin24 helin24 deleted the revert-idea branch April 2, 2026 16:06
helin24 added a commit to helin24/flutter-intellij that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants