Skip to content

[docs] stop specifying a JDK version#8911

Merged
auto-submit[bot] merged 1 commit into
mainfrom
pq-docs-less-jdk
Apr 17, 2026
Merged

[docs] stop specifying a JDK version#8911
auto-submit[bot] merged 1 commit into
mainfrom
pq-docs-less-jdk

Conversation

@pq
Copy link
Copy Markdown
Collaborator

@pq pq commented Apr 17, 2026

Stale and not adding value. (Destined to get stale again too.)


Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

@pq pq added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Apr 17, 2026
@pq pq requested review from cj-radcliff and helin24 April 17, 2026 01:22
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the explicit mention of JDK version 23 from the environment setup section in CONTRIBUTING.md to reduce documentation staleness. Feedback indicates that several other hardcoded references to version 23 remain in the file, which are inconsistent with the project's actual requirement of JDK 21 and should be updated to generic placeholders.

Comment thread CONTRIBUTING.md
@auto-submit auto-submit Bot merged commit c471478 into main Apr 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants