Skip to content

[friction] ignore bin#8952

Merged
pq merged 2 commits into
flutter:mainfrom
pq:friction_ignoreBin
May 8, 2026
Merged

[friction] ignore bin#8952
pq merged 2 commits into
flutter:mainfrom
pq:friction_ignoreBin

Conversation

@pq
Copy link
Copy Markdown
Collaborator

@pq pq commented May 6, 2026

Agents love to create stuff in bin which we have to manually ignore. The right thing to do is to git ignore the directory.


Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the bin/ directory to the .gitignore file. A review comment suggests using the root-relative path /bin/ instead to avoid unintentionally ignoring legitimate Dart source files located in subdirectories, which is a common structure in Flutter projects.

Comment thread .gitignore Outdated
@pq pq requested a review from helin24 May 8, 2026 15:50
@pq pq merged commit 9a54f5b into flutter:main May 8, 2026
8 checks passed
@pq pq deleted the friction_ignoreBin branch May 8, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants