Skip to content

Change survey query params#8967

Merged
helin24 merged 2 commits into
flutter:mainfrom
helin24:survey
May 11, 2026
Merged

Change survey query params#8967
helin24 merged 2 commits into
flutter:mainfrom
helin24:survey

Conversation

@helin24
Copy link
Copy Markdown
Member

@helin24 helin24 commented May 8, 2026

Fixes #8934

Sample URL: https://example.com/survey?Source=Android+Studio&DartVersion=3.13.0-97.0.dev%0A&FlutterVersion=3.44.0-1.0.pre-464

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the survey notification logic to include the IDE name in the survey URL parameters. The review feedback correctly identifies that the IDE name and version strings must be URL-encoded to handle spaces and special characters, and provides the necessary imports to implement this change.

Comment thread src/io/flutter/survey/FlutterSurveyNotifications.java Outdated
Comment thread src/io/flutter/survey/FlutterSurveyNotifications.java
@helin24 helin24 requested a review from pq May 8, 2026 19:50
@helin24
Copy link
Copy Markdown
Member Author

helin24 commented May 8, 2026

CC @DanTup @kenzieschmoll

@helin24 helin24 changed the title Change query params Change survey query params May 8, 2026
@helin24 helin24 merged commit 69d1b88 into flutter:main May 11, 2026
8 checks passed
@helin24 helin24 deleted the survey branch May 11, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send DASH__IDE_NAME for survey

2 participants