You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a field called macUTIs, but it will be used for iOS too. We should rename it, with aliases (using get and set) to preserve backward compatibility.
Hi @stuartmorgan, I was looking into starting contributing a bit to the project.
We looked into the code and discovered that both the Mac and iOS implementation use the property macUTIs. We modified the main example to include this field, and it's currently working on the different platforms.
Furthermore, we believe that changing macUTIs to cupertinoUTIs would be a good replacement but, it will generate a breaking change. Can you elaborate on the way you proposed to preserve backward compatibility?
Furthermore, we believe that changing macUTIs to cupertinoUTIs would be a good replacement
cupertino is a confusing term in many contexts, and in the framework it explicitly means "iOS" not "iOS and macOS", so I definitely don't want to use it here. We should just call it uniformTypeIdentifiers, since that's an unambiguous term.
Can you elaborate on the way you proposed to preserve backward compatibility?
macUTIs can be left as a synthetic property that forwards to the new name. I.e., a construction like:
class Foo {
bool foo = false;
bool get bar => foo;
set bar(bool value) { foo = value; }
}
Once that's published and file_selector has been updated to use the new names, the old name can be @Deprecated.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
juandausa commentedon Sep 14, 2022
Hi @stuartmorgan, I was looking into starting contributing a bit to the project.
We looked into the code and discovered that both the Mac and iOS implementation use the property
macUTIs. We modified the main example to include this field, and it's currently working on the different platforms.Furthermore, we believe that changing
macUTIstocupertinoUTIswould be a good replacement but, it will generate a breaking change. Can you elaborate on the way you proposed to preserve backward compatibility?Thanks,
stuartmorgan-g commentedon Sep 14, 2022
cupertinois a confusing term in many contexts, and in the framework it explicitly means "iOS" not "iOS and macOS", so I definitely don't want to use it here. We should just call ituniformTypeIdentifiers, since that's an unambiguous term.macUTIscan be left as a synthetic property that forwards to the new name. I.e., a construction like:Once that's published and
file_selectorhas been updated to use the new names, the old name can be@Deprecated.juandausa commentedon Sep 14, 2022
Hi @stuartmorgan we appreciate your prompt response and clarification, we'll take this approach.
[file_selector] Remove uses of `macUTIs` (#3859)
[file_selector] Deprecates `macUTIs`
[file_selector] Deprecates `macUTIs` (#3888)
github-actions commentedon May 17, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[file_selector] Deprecates `macUTIs` (flutter#3888)
[file_selector] Deprecates `macUTIs` (flutter#3888)
[file_selector] Deprecates `macUTIs` (flutter#3888)