Skip to content

Implement pushRoute API on iOS #10399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
szakarias opened this issue May 31, 2017 · 3 comments · Fixed by #10415
Closed

Implement pushRoute API on iOS #10399

szakarias opened this issue May 31, 2017 · 3 comments · Fixed by #10415
Labels
engine flutter/engine repository. See also e: labels. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically

Comments

@szakarias
Copy link
Contributor

Hook up the pushRoute method on the FlutterView class on Android. Also something similar is desirable on iOS in order to be able to initiate Flutter code with different initial routes.
@Hixie Hixie added engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically labels May 31, 2017
@Hixie Hixie added this to the 4: Make shippers happy milestone May 31, 2017
@jason-simmons jason-simmons mentioned this issue May 31, 2017
Merged
jason-simmons added a commit to jason-simmons/flutter that referenced this issue May 31, 2017
@jason-simmons
Implement a pushRoute service to satisfy the FlutterView.pushRoute API
0ef217a 
Fixes flutter#10399
jason-simmons added a commit that referenced this issue Jun 1, 2017
@jason-simmons
Implement a pushRoute service to satisfy the FlutterView.pushRoute API (
0e97637 
#10415)

Fixes #10399
@jason-simmons jason-simmons changed the title Hook up pushRoute Implement pushRoute API on iOS Jun 1, 2017
@jason-simmons
Copy link
Member

Reopening to reflect that this feature should be implemented on iOS

@cbracken

@jason-simmons jason-simmons reopened this Jun 1, 2017
@mravn-google mravn-google mentioned this issue Jun 1, 2017
Closed
@Hixie Hixie added the f: routes Navigator, Router, and related APIs. label Mar 8, 2018
@goderbauer goderbauer added platform-ios iOS applications specifically and removed platform-android Android applications specifically labels Dec 27, 2018
@xster
Copy link
Member

xster commented Jan 4, 2019

There's a pushRoute on FlutterViewController.

@xster xster closed this as completed Jan 4, 2019
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a pushRoute service to satisfy the FlutterView.pushRoute API jason-simmons/flutter
5 participants
@xster @Hixie @goderbauer @szakarias @jason-simmons